Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 16410007: Get the api docs generated for the crypto package (Closed)

Created:
7 years, 6 months ago by Søren Gjesse
Modified:
7 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get the api docs generated for the crypto package Then library name of dart.crypto caused the api docs to not be generated. Removed some abstract modifiers and class HashException R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M pkg/crypto/lib/crypto.dart View 6 chunks +6 lines, -17 lines 0 comments Download
M pkg/crypto/lib/src/crypto_utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/crypto/lib/src/hash_utils.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/crypto/lib/src/hmac.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/crypto/lib/src/md5.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/crypto/lib/src/sha1.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/crypto/lib/src/sha256.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/crypto/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 6 months ago (2013-06-06 16:04:27 UTC) #1
floitsch
LGTM.
7 years, 6 months ago (2013-06-06 16:08:59 UTC) #2
Søren Gjesse
7 years, 6 months ago (2013-06-06 16:14:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23693 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698