Issue 16409016: Fixing up element_types_test to work properly in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16409016: Fixing up element_types_test to work properly in checked mode. (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing up element_types_test to work properly in checked mode, adding a few more element constructors. Basically the constructors were failing in checked mode when they returned UnknownElement rather than the expected type. I adjusted the tests to account for this. BUG=10796 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=23885

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -226 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	tests/html/element_types_test.dart	View	1 chunk	+101 lines, -223 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tools/dom/dom.json	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 6 months ago (2013-06-11 22:42:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23885 (presubmit successful).

Expand Messages | Collapse Messages