Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1640323004: Start switching hijacking to use StreamChannel. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/shelf@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -23 lines) Patch
M CHANGELOG.md View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/src/request.dart View 3 chunks +18 lines, -8 lines 0 comments Download
M pubspec.yaml View 2 chunks +6 lines, -1 line 0 comments Download
M test/hijack_test.dart View 5 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nweiz
Once this releases (after stream_channel obviously), I plan to send out an email to dart-cloud-server ...
4 years, 11 months ago (2016-01-28 06:45:06 UTC) #2
kevmoo
LGTM - modulu gitmodules https://codereview.chromium.org/1640323004/diff/1/.gitmodules File .gitmodules (right): https://codereview.chromium.org/1640323004/diff/1/.gitmodules#newcode1 .gitmodules:1: [submodule "third_party/barback-0.14.1+4"] Unintentional?
4 years, 10 months ago (2016-01-28 18:37:11 UTC) #3
nweiz
https://codereview.chromium.org/1640323004/diff/1/.gitmodules File .gitmodules (right): https://codereview.chromium.org/1640323004/diff/1/.gitmodules#newcode1 .gitmodules:1: [submodule "third_party/barback-0.14.1+4"] On 2016/01/28 18:37:11, kevmoo wrote: > Unintentional? ...
4 years, 10 months ago (2016-01-28 18:49:03 UTC) #4
nweiz
4 years, 10 months ago (2016-01-28 18:49:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
790d193e4ef9ebe7b0ac67aa66d59723d734b64b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698