Support deploying an npm package exporting a formatCode method.

Support deploying an npm package exporting a formatCode method.

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/dart_style/commit/fd89540f05a0d21b7767ebc3add9db15a7f22623

[Jacob, 2016-01-27 02:50:09]

jacobr@google.com changed reviewers:
+ rnystrom@google.com

[Jacob, 2016-01-27 02:50:10]

You can see the node module ground out by running
pub run grinder npm here

https://www.npmjs.com/package/dart-style
The generated pub package appears to work with ts2dart
https://github.com/angular/ts2dart/pull/327

[Bob Nystrom, 2016-01-27 20:37:13]

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dart
File bin/node_format_service.dart (right):

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dar...
bin/node_format_service.dart:1: // Copyright (c) 2015, the Dart project authors.
 Please see the AUTHORS file
bin/ isn't the right place for this since it's not a Dart executable end users
should be able to run.

How about tool/?

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dar...
bin/node_format_service.dart:11: int width = 80;
Is this part of the public API, or just a constant? If it's a constant, you can
just delete it and rely on the default pageWidth in new DartFormatter().

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dar...
bin/node_format_service.dart:28: code: new DartFormatter(pageWidth:
width).format(source));
My little web script isn't a good example. How about getting rid of some of the
redundancy between the two cases by only constructing a single DartFormatter?

https://codereview.chromium.org/1640023002/diff/1/tool/grind.dart
File tool/grind.dart (right):

https://codereview.chromium.org/1640023002/diff/1/tool/grind.dart#newcode11
tool/grind.dart:11: import 'dart:convert';
Nit: Put "dart:" imports above other ones with a blank line after.

[Jacob, 2016-01-27 20:56:32]

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dart
File bin/node_format_service.dart (right):

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dar...
bin/node_format_service.dart:1: // Copyright (c) 2015, the Dart project authors.
 Please see the AUTHORS file
On 2016/01/27 20:37:13, Bob Nystrom wrote:
> bin/ isn't the right place for this since it's not a Dart executable end users
> should be able to run.
> 
> How about tool/?

Done.

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dar...
bin/node_format_service.dart:11: int width = 80;
On 2016/01/27 20:37:13, Bob Nystrom wrote:
> Is this part of the public API, or just a constant? If it's a constant, you
can
> just delete it and rely on the default pageWidth in new DartFormatter().

Done.
Was going to make it part of the api but it doesn't really matter as my dream of
120 character line dart strings isn't going to happen.

https://codereview.chromium.org/1640023002/diff/1/bin/node_format_service.dar...
bin/node_format_service.dart:28: code: new DartFormatter(pageWidth:
width).format(source));
On 2016/01/27 20:37:13, Bob Nystrom wrote:
> My little web script isn't a good example. How about getting rid of some of
the
> redundancy between the two cases by only constructing a single DartFormatter?

Done.

https://codereview.chromium.org/1640023002/diff/1/tool/grind.dart
File tool/grind.dart (right):

https://codereview.chromium.org/1640023002/diff/1/tool/grind.dart#newcode11
tool/grind.dart:11: import 'dart:convert';
On 2016/01/27 20:37:13, Bob Nystrom wrote:
> Nit: Put "dart:" imports above other ones with a blank line after.

why doesn't the formatter do that for me?

[Bob Nystrom, 2016-01-27 21:53:46]

A few more things then LGTM!

https://codereview.chromium.org/1640023002/diff/20001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1640023002/diff/20001/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.2.5
5-dev

(Unless you're planning to publish a new version of dart_style to pub
immediately.)

https://codereview.chromium.org/1640023002/diff/20001/pubspec.yaml#newcode14
pubspec.yaml:14: node_preamble: ^1.0.0
Oh, I should have mentioned this earlier, but these can and should be
dev_dependencies.

https://codereview.chromium.org/1640023002/diff/20001/tool/grind.dart
File tool/grind.dart (right):

https://codereview.chromium.org/1640023002/diff/20001/tool/grind.dart#newcode12
tool/grind.dart:12: import 'dart:io';
The blank line is good, but these go *above* the package: ones. :)

[Jacob, 2016-01-27 22:01:07]

https://codereview.chromium.org/1640023002/diff/20001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1640023002/diff/20001/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.2.5
On 2016/01/27 21:53:46, Bob Nystrom wrote:
> 5-dev
> 
> (Unless you're planning to publish a new version of dart_style to pub
> immediately.)

I really don't care. Technically I have published 0.2.5 already to npm not that
it really matters.

https://codereview.chromium.org/1640023002/diff/20001/pubspec.yaml#newcode14
pubspec.yaml:14: node_preamble: ^1.0.0
On 2016/01/27 21:53:46, Bob Nystrom wrote:
> Oh, I should have mentioned this earlier, but these can and should be
> dev_dependencies.

Done.

[Jacob, 2016-01-28 17:45:57]

Description was changed from

==========
Support deploying an npm package exporting a formatCode method.

BUG=
==========

to

==========
Support deploying an npm package exporting a formatCode method.

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/dart_style/commit/fd89540f05a0d21b7767ebc3add9db...
==========

[Jacob, 2016-01-28 17:45:58]

Committed patchset #5 (id:80001) manually as
fd89540f05a0d21b7767ebc3add9db15a7f22623 (presubmit successful).