Issue 16398006: BREAKING CHANGE: Remove === and !== in the VM compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16398006: BREAKING CHANGE: Remove === and !== in the VM compiler (Closed)

Created:
7 years, 6 months ago by hausner

Modified:
7 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

BREAKING CHANGE: Remove === and !== in the VM compiler This change is long overdue. Fixed the last places where we still used ===. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23751

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -23 lines)			Patch
M	runtime/lib/expando_patch.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/canonical_const_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/compile_time_constant8_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/compile_time_constant_b_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/compile_time_constant_d_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/compile_time_constant_e_test.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/language/licm_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/typed_equality_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

hausner

7 years, 6 months ago (2013-06-07 16:31:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r23751 (presubmit successful).