Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1639643002: Add StreamChannel.transform(). (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stream_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M lib/stream_channel.dart View 1 3 chunks +18 lines, -0 lines 0 comments Download
A test/stream_channel_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 11 months ago (2016-01-26 01:38:08 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1639643002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1639643002/diff/1/pubspec.yaml#newcode14 pubspec.yaml:14: async: {path: ../async} ?
4 years, 10 months ago (2016-01-26 20:45:13 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2016-01-26 23:28:10 UTC) #3
nweiz
https://codereview.chromium.org/1639643002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1639643002/diff/1/pubspec.yaml#newcode14 pubspec.yaml:14: async: {path: ../async} On 2016/01/26 20:45:13, Bob Nystrom wrote: ...
4 years, 10 months ago (2016-01-26 23:28:18 UTC) #4
nweiz
4 years, 10 months ago (2016-01-26 23:28:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2e37ad5e09911199624070f70fc17e6719fa4245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698