Issue 16390002: Make ImmutableArray a sub class of AllStatic.

Issue 16390002: Make ImmutableArray a sub class of AllStatic. (Closed)

Created:
7 years, 6 months ago by siva

Modified:
7 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make ImmutableArray a sub class of AllStatic. This enables Array to be a FINAL_HEAP_OBJECT and the operators '=' and '^=' would be a simpler implementation which does not require a call to initializeHandle(). R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23884

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -36 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	2 chunks	+26 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	5 chunks	+7 lines, -17 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4	5 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2 3 4	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 2 3 4	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with a question about better naming. -Ivan https://codereview.chromium.org/16390002/diff/19001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/16390002/diff/19001/runtime/vm/raw_object.h#newcode16 runtime/vm/raw_object.h:16: #define ...

7 years, 6 months ago (2013-06-11 20:37:35 UTC) #3

siva

https://codereview.chromium.org/16390002/diff/19001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/16390002/diff/19001/runtime/vm/raw_object.h#newcode16 runtime/vm/raw_object.h:16: #define CLASS_LIST_NO_OBJECT_OR_STRING(V) \ Changed name to CLASS_LIST_NO_OBJECT_NOR_STRING_NOR_ARRAY On 2013/06/11 ...

7 years, 6 months ago (2013-06-11 21:43:39 UTC) #4

siva

7 years, 6 months ago (2013-06-11 21:52:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r23884 (presubmit successful).

Expand Messages | Collapse Messages