Issue 163853004: Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163853004: Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField." (Closed)

Created:
6 years, 10 months ago by floitsch

Modified:
6 years, 10 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField." Revert "Update status file." This reverts commit r32654 and r32661. Committed: https://code.google.com/p/dart/source/detail?r=32665

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -54 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	tests/language/null2_test.dart	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	tests/language/null_test.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tests/lib/lib.status	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	tests/lib/mirrors/null2_test.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	tests/lib/mirrors/null_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

TBR. Still some issues with browsers (apparently). Will fix tomorrow.

6 years, 10 months ago (2014-02-13 18:36:23 UTC) #1

floitsch

Committed patchset #1 manually as r32665 (presubmit successful).

6 years, 10 months ago (2014-02-13 18:36:58 UTC) #2

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages