Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1638183002: Add IsolateChannel.connect* constructors. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stream_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add IsolateChannel.connect* constructors. These constructors use a lightweight protocol to establish a two-way connection over a previously-one-way connection. R=rnystrom@google.com Committed: https://github.com/dart-lang/stream_channel/commit/f72ea5afa0edd64e18c03cad890eb8e7085bd28e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -154 lines) Patch
M lib/src/isolate_channel.dart View 2 chunks +61 lines, -111 lines 1 comment Download
A + lib/src/isolate_channel/send_port_sink.dart View 6 chunks +8 lines, -43 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M test/isolate_channel_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 11 months ago (2016-01-27 02:44:35 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1638183002/diff/1/lib/src/isolate_channel.dart File lib/src/isolate_channel.dart (right): https://codereview.chromium.org/1638183002/diff/1/lib/src/isolate_channel.dart#newcode84 lib/src/isolate_channel.dart:84: var receivePort = new ReceivePort(); Go home, Reitveld ...
4 years, 11 months ago (2016-01-27 20:39:47 UTC) #2
nweiz
4 years, 11 months ago (2016-01-27 23:28:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f72ea5afa0edd64e18c03cad890eb8e7085bd28e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698