Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 16381003: Quick check for self in InterfaceTypeImpl.getLeastUpperBound() (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Quick check for self in InterfaceTypeImpl.getLeastUpperBound() This reduces co19 time from 60 to 45 seconds for DDA. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -48 lines) Patch
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/InterfaceTypeImpl.java View 1 chunk +5 lines, -0 lines 0 comments Download
pkg/analyzer_experimental/lib/src/generated/element.dart View 1 chunk +3 lines, -0 lines 0 comments Download
pkg/analyzer_experimental/lib/src/generated/error.dart View 1 chunk +2 lines, -2 lines 0 comments Download
pkg/analyzer_experimental/lib/src/generated/html.dart View 1 chunk +44 lines, -0 lines 0 comments Download
pkg/analyzer_experimental/lib/src/generated/resolver.dart View 6 chunks +64 lines, -34 lines 0 comments Download
pkg/analyzer_experimental/test/generated/resolver_test.dart View 5 chunks +37 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 6 months ago (2013-06-06 18:53:56 UTC) #1
Brian Wilkerson
LGTM
7 years, 6 months ago (2013-06-06 19:26:29 UTC) #2
scheglov
7 years, 6 months ago (2013-06-06 19:29:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23714 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698