Issue 16378004: Revert change 23636 as it is causing issues on dartium. Will resubmit after investigating the darti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16378004: Revert change 23636 as it is causing issues on dartium. Will resubmit after investigating the darti… (Closed)

Created:
7 years, 6 months ago by siva

Modified:
7 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Revert change 23636 as it is causing issues on dartium. Will resubmit after investigating the dartium failure. Committed: https://code.google.com/p/dart/source/detail?r=23641

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -47 lines)			Patch
M	runtime/lib/isolate.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/platform/utils.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	runtime/vm/benchmark_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/class_table.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_observers.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	1 chunk	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/debuginfo.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/megamorphic_cache_table.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

siva

7 years, 6 months ago (2013-06-05 17:28:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r23641 (presubmit successful).