Emit named parameter information in declaration order.

Emit named parameter information in declaration order.

R=floitsch@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32880

Committed: https://code.google.com/p/dart/source/detail?r=33017

[kasperl, 2014-02-14 14:02:52]

LGTM! Thanks, Karl.

[karlklose, 2014-02-18 10:10:00]

PTAL.

After this change runtime invocations of functions is a bit slower, because we
have to sort the named parameters. I plan to address this with caching of
reflection info.

[floitsch, 2014-02-20 15:03:32]

LGTM.

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
sdk/lib/_internal/lib/js_helper.dart:422: if (!areOptionalParametersNamed ||
that should fit on one line.

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
sdk/lib/_internal/lib/js_helper.dart:428: int index =
cachedSortedIndices[parameter - requiredParameterCount];
I would prefer:
int index = sortedIndex(parameter - requiredParameterCount);

and let sortedIndex keep a cache.

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
sdk/lib/_internal/lib/js_helper.dart:975: var parameterName =
info.parameterNameInOrder(i + info.requiredParameterCount);
long line.

[karlklose, 2014-02-21 09:15:27]

Thanks, Florian.

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
sdk/lib/_internal/lib/js_helper.dart:422: if (!areOptionalParametersNamed ||
On 2014/02/20 15:03:32, floitsch wrote:
> that should fit on one line.

Done.

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
sdk/lib/_internal/lib/js_helper.dart:428: int index =
cachedSortedIndices[parameter - requiredParameterCount];
On 2014/02/20 15:03:32, floitsch wrote:
> I would prefer:
> int index = sortedIndex(parameter - requiredParameterCount);
> 
> and let sortedIndex keep a cache.

Done.

https://codereview.chromium.org/163773003/diff/120001/sdk/lib/_internal/lib/j...
sdk/lib/_internal/lib/js_helper.dart:975: var parameterName =
info.parameterNameInOrder(i + info.requiredParameterCount);
On 2014/02/20 15:03:32, floitsch wrote:
> long line.

Done.

[karlklose, 2014-02-21 09:31:17]

Committed patchset #5 manually as r32880 (presubmit successful).

[blois, 2014-02-24 18:03:15]

It appears that this CL may have broken an Angular test:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-drt-linux-1-2-...

Repro command:
python tools/test.py -mrelease -cdart2js -rdrt --use-sdk --write-debug-log
--write-test-outcome-log -t60
pkg/third_party/angular_tests/browser_test/directive/ng_pluralize

If I back out this change then the test appears to pass for me.

[karlklose, 2014-02-25 12:42:43]

On 2014/02/24 18:03:15, blois wrote:
> It appears that this CL may have broken an Angular test:
>
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-drt-linux-1-2-...
> 
> Repro command:
> python tools/test.py -mrelease -cdart2js -rdrt --use-sdk --write-debug-log
> --write-test-outcome-log -t60
> pkg/third_party/angular_tests/browser_test/directive/ng_pluralize
> 
> If I back out this change then the test appears to pass for me.

PTAL.

[kasperl, 2014-02-25 12:44:15]

I assume this is a patch on top of the (reverted) original change? If so, it
LGTM.

[karlklose, 2014-02-25 12:52:36]

On 2014/02/25 12:44:15, kasperl wrote:
> I assume this is a patch on top of the (reverted) original change? If so, it
> LGTM.

Yes, it is (I forgot to leave a 'reverted in ...' reply).

Thanks, Kasper!

[karlklose, 2014-02-25 13:18:05]

Committed patchset #6 manually as r33017 (presubmit successful).