Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 16375005: Fix http_content_length_test by not closing the server from the client. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix http_content_length_test by not closing the server from the client. This would invoke socket.destory calls, leading to the socket dying normally, before an error can occour. BUG=https://code.google.com/p/dart/issues/detail?id=10934 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tests/standalone/io/http_content_length_test.dart View 6 chunks +12 lines, -10 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 6 months ago (2013-06-10 07:45:45 UTC) #1
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-10 08:06:02 UTC) #2
Anders Johnsen
7 years, 6 months ago (2013-06-10 10:20:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23802 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698