Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 16374002: Mark the "completes" matcher as final. (Closed)

Created:
7 years, 6 months ago by nweiz
Modified:
7 years, 6 months ago
Reviewers:
gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark the "completes" matcher as final. R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=23618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/scheduled_test/lib/src/scheduled_future_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/src/future_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 6 months ago (2013-06-04 21:12:21 UTC) #1
gram
lgtm
7 years, 6 months ago (2013-06-04 22:13:58 UTC) #2
nweiz
7 years, 6 months ago (2013-06-04 22:32:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698