Let deferred load work from worker isolates.

Let deferred load work from worker isolates.

If we try to load a deferred library from a worker-isolate we cannot
inject a script tag because we do not have access to the dom. Instead we
make an XMLHttpRequest object and load the code with that.

I tried to take some care of error handling introducing a new exception.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32693

Committed: https://code.google.com/p/dart/source/detail?r=32695

Committed: https://code.google.com/p/dart/source/detail?r=32698

Committed: https://code.google.com/p/dart/source/detail?r=32700

[floitsch, 2014-02-13 15:28:52]

LGTM.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
File sdk/lib/_internal/lib/async_patch.dart (right):

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:6: import 'dart:_js_helper' show
Primitives, convertDartClosureToJS;
Keep one line between comment and first import.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:83: throw(new
DeferredLoadException("Loading $uri failed."));
throw is not a function.
throw new Deferred ...

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:91: enterJsAsync();
Use the completer to your advantage and group the enterJsAsync and leaveJsAsync:

enterJsAsync();
Future result = completer.future.whenComplete(leaveJsAsync);
...
return result;

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:98: if (JS('int', '#.status', xhr) !=
200) {
In this case you wouldn't have left the async scope.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:116: JS('void',
'#.addEventListener("error", #, false)',
var fail = convertDartClosureToJS((event) {
  completer.completeError( ... );
});

JS('void', '#.addEventListener("error", #, false)', xhr, fail);
JS('void', '#.addEventListener("abort", #, false)', xhr, fail);

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/isolat...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:36: /// Marks entering a JavaScript
async operation to keep the worker alive.
duplicated line.

[sigurdm, 2014-02-14 12:08:05]

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
File sdk/lib/_internal/lib/async_patch.dart (right):

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:6: import 'dart:_js_helper' show
Primitives, convertDartClosureToJS;
On 2014/02/13 15:28:52, floitsch wrote:
> Keep one line between comment and first import.

Done.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:83: throw(new
DeferredLoadException("Loading $uri failed."));
On 2014/02/13 15:28:52, floitsch wrote:
> throw is not a function.
> throw new Deferred ...

Done.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:91: enterJsAsync();
On 2014/02/13 15:28:52, floitsch wrote:
> Use the completer to your advantage and group the enterJsAsync and
leaveJsAsync:
> 
> enterJsAsync();
> Future result = completer.future.whenComplete(leaveJsAsync);
> ...
> return result;
Much better!

Done.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:98: if (JS('int', '#.status', xhr) !=
200) {
On 2014/02/13 15:28:52, floitsch wrote:
> In this case you wouldn't have left the async scope.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/async_...
sdk/lib/_internal/lib/async_patch.dart:116: JS('void',
'#.addEventListener("error", #, false)',
On 2014/02/13 15:28:52, floitsch wrote:
> var fail = convertDartClosureToJS((event) {
>   completer.completeError( ... );
> });
> 
> JS('void', '#.addEventListener("error", #, false)', xhr, fail);
> JS('void', '#.addEventListener("abort", #, false)', xhr, fail);

Done.

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/isolat...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/163733003/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:36: /// Marks entering a JavaScript
async operation to keep the worker alive.
On 2014/02/13 15:28:52, floitsch wrote:
> duplicated line.

Done.

[sigurdm, 2014-02-14 12:13:09]

Committed patchset #2 manually as r32693 (presubmit successful).

[sigurdm, 2014-02-14 12:38:42]

TBR

[sigurdm, 2014-02-14 12:44:26]

Committed patchset #3 manually as r32695 (presubmit successful).

[Florian Schneider, 2014-02-14 12:56:22]

https://codereview.chromium.org/163733003/diff/110009/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/163733003/diff/110009/tests/lib/lib.status#ne...
tests/lib/lib.status:276: async/deferred/deferred_fail_to_load_test: Fail, OK
If it is always failing, the expectation should be "Fail" so that this line will
be reliably removed once the VM supports deferred loading.

https://codereview.chromium.org/163733003/diff/110009/tests/lib/lib.status#ne...
tests/lib/lib.status:279: async/deferred/deferred_in_isolate_test: Fail, OK
If it is always failing, the expectation should be "Fail" so that this line will
be reliably removed once the VM supports deferred loading.

[sigurdm, 2014-02-14 13:08:16]

https://codereview.chromium.org/163733003/diff/110009/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/163733003/diff/110009/tests/lib/lib.status#ne...
tests/lib/lib.status:276: async/deferred/deferred_fail_to_load_test: Fail, OK
On 2014/02/14 12:56:22, Florian Schneider wrote:
> If it is always failing, the expectation should be "Fail" so that this line
will
> be reliably removed once the VM supports deferred loading.

Done.

https://codereview.chromium.org/163733003/diff/110009/tests/lib/lib.status#ne...
tests/lib/lib.status:279: async/deferred/deferred_in_isolate_test: Fail, OK
On 2014/02/14 12:56:22, Florian Schneider wrote:
> If it is always failing, the expectation should be "Fail" so that this line
will
> be reliably removed once the VM supports deferred loading.

Done.

[sigurdm, 2014-02-14 13:10:22]

Committed patchset #4 manually as r32698 (presubmit successful).

[sigurdm, 2014-02-14 13:34:32]

TBR

[sigurdm, 2014-02-14 14:04:28]

Committed patchset #5 manually as r32700 (presubmit successful).