Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Issue 1637193003: Add suite information to the JSON reporter. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
alexander.doroshko, alexander.doroshko, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : analysis #

Patch Set 3 : fix changelog #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -135 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M json_reporter.md View 5 chunks +48 lines, -1 line 2 comments Download
M json_reporter.schema.json View 5 chunks +28 lines, -5 lines 0 comments Download
M lib/src/runner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/runner/load_suite.dart View 1 3 chunks +7 lines, -7 lines 0 comments Download
M lib/src/runner/loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/reporter/compact.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/runner/reporter/expanded.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/runner/reporter/json.dart View 1 6 chunks +40 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/json_reporter_test.dart View 14 chunks +143 lines, -113 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nweiz
4 years, 11 months ago (2016-01-27 01:04:51 UTC) #2
alexander.doroshko
lgtm
4 years, 11 months ago (2016-01-27 10:19:30 UTC) #4
alexander.doroshko
lgtm lgtm
4 years, 11 months ago (2016-01-27 10:19:32 UTC) #5
kevmoo
lgtm
4 years, 10 months ago (2016-01-28 20:40:49 UTC) #6
nweiz
Committed patchset #3 (id:40001) manually as bdeff621359170be3ef58c60e1acfef8ef6dc423 (presubmit successful).
4 years, 10 months ago (2016-01-28 21:41:48 UTC) #8
alexander.doroshko
https://codereview.chromium.org/1637193003/diff/40001/json_reporter.md File json_reporter.md (right): https://codereview.chromium.org/1637193003/diff/40001/json_reporter.md#newcode309 json_reporter.md:309: doesn't exist at all). Its path is relative to ...
4 years, 10 months ago (2016-02-11 14:26:43 UTC) #9
nweiz
4 years, 10 months ago (2016-02-12 00:58:25 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1637193003/diff/40001/json_reporter.md
File json_reporter.md (right):

https://codereview.chromium.org/1637193003/diff/40001/json_reporter.md#newcod...
json_reporter.md:309: doesn't exist at all). Its path is relative to the root of
the current package.
On 2016/02/11 14:26:43, alexander.doroshko wrote:
> Spec says that Suite.path is relative to the current package root, but in fact
> we see that absolute paths are emitted. 
> Current implementation in IntelliJ IDEA works fine with absolute paths, so
we'd
> be happy with just a spec update.
> If you believe that JSON reporter should be changed to emit relative paths
> please let us know asap as IntelliJ IDEA and WebStorm releases are very soon.

Good to know. I put out https://codereview.chromium.org/1690053004 to update the
docs.

I suspect what happens here is that we emit absolute paths if we're passed
absolute paths and vice versa, but I don't want to guarantee that behavior.

Powered by Google App Engine
This is Rietveld 408576698