Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1636933002: Fix --pub-serve's path separator on Windows. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix --pub-serve's path separator on Windows. See #385 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/2b73307c9cbd96c03c5c6af6598ea2932ec8dc21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/src/runner/browser/server.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 11 months ago (2016-01-26 01:41:13 UTC) #1
kevmoo
LGTM - but no new tests?
4 years, 11 months ago (2016-01-26 02:08:18 UTC) #2
nweiz
On 2016/01/26 02:08:18, kevmoo wrote: > LGTM - but no new tests? As far as ...
4 years, 11 months ago (2016-01-26 22:59:07 UTC) #3
nweiz
4 years, 11 months ago (2016-01-26 22:59:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b73307c9cbd96c03c5c6af6598ea2932ec8dc21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698