Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 16365017: Add debugging info to browser controller. (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add debugging info to browser controller. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=23903

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M tools/testing/dart/browser_controller.dart View 10 chunks +29 lines, -9 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
7 years, 6 months ago (2013-06-12 12:47:08 UTC) #1
kustermann
https://codereview.chromium.org/16365017/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/16365017/diff/1/tools/testing/dart/browser_controller.dart#newcode626 tools/testing/dart/browser_controller.dart:626: browser.id = new_id; Please move this 2 lines down ...
7 years, 6 months ago (2013-06-12 12:52:09 UTC) #2
kustermann
lgtm
7 years, 6 months ago (2013-06-12 12:52:31 UTC) #3
ricow1
https://codereview.chromium.org/16365017/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/16365017/diff/1/tools/testing/dart/browser_controller.dart#newcode626 tools/testing/dart/browser_controller.dart:626: browser.id = new_id; On 2013/06/12 12:52:09, kustermann wrote: > ...
7 years, 6 months ago (2013-06-12 12:54:30 UTC) #4
ricow1
7 years, 6 months ago (2013-06-12 12:54:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r23903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698