Share DartSdk instance in Java-based CLI Dart Analyzer.

Share DartSdk instance in Java-based CLI Dart Analyzer.

Running all shared tests is just 1:40 with this CL!

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=23603

[Brian Wilkerson, 2013-06-04 16:45:11]

LGTM if it actually improves execution time, but I'd like to understand why it
would.

https://codereview.chromium.org/16359011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java
(right):

https://codereview.chromium.org/16359011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java:77:
this.sdk = getSdk(options.getDartSdkPath());
I don't understand the need for this change. As far as I can see from looking at
AnalyzerMain, we only ever create a single AnalyzerImpl per run. If that's true,
then we were only creating a single SDK and there's no actual savings involved.
What am I missing?

[scheglov, 2013-06-04 16:54:09]

https://codereview.chromium.org/16359011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java
(right):

https://codereview.chromium.org/16359011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java:77:
this.sdk = getSdk(options.getDartSdkPath());
On 2013/06/04 16:45:11, Brian Wilkerson wrote:
> I don't understand the need for this change. As far as I can see from looking
at
> AnalyzerMain, we only ever create a single AnalyzerImpl per run. If that's
true,
> then we were only creating a single SDK and there's no actual savings
involved.
> What am I missing?

When we run with --batch, we use single process to run sequence of tests.
However each separate test is ran using new instance of AnalyzerImpl.

[scheglov, 2013-06-04 16:54:46]

Committed patchset #1 manually as r23603 (presubmit successful).