Basic dart^2 analyzer tests running.

Basic dart^2 analyzer tests running.

Status file only for co19 now, more status files in next CL.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=23602

[Brian Wilkerson, 2013-06-04 15:56:47]

LGTM. Ideally we wouldn't need a separate status file for it, but I guess we're
either not at that point or it's too hard to share a single file.

https://codereview.chromium.org/16357010/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/error_formatter.dart (right):

https://codereview.chromium.org/16357010/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/error_formatter.dart:126: out.write('\n');
Does writeln produce platform specific end-of-line marker? If so, wouldn't we
want to use it here?

[scheglov, 2013-06-04 16:08:52]

Yes, it is not possible to share status files yet.

https://codereview.chromium.org/16357010/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/error_formatter.dart (right):

https://codereview.chromium.org/16357010/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/error_formatter.dart:126: out.write('\n');
On 2013/06/04 15:56:47, Brian Wilkerson wrote:
> Does writeln produce platform specific end-of-line marker? If so, wouldn't we
> want to use it here?

Every implementation I see write \n, but may be there is some platform specific
magic which I don't see.
Fixed.

[scheglov, 2013-06-04 16:09:23]

Committed patchset #1 manually as r23602 (presubmit successful).

[ahe, 2013-06-10 07:20:13]

What is this change about?

Why are you making changes to the test infrastructure without coordinating with
the test team?

Are you planning to ship sdk/bin/dart2analyzer as part of the SDK, if so why do
we need to analyzers in the SDK?

[ahe, 2013-06-10 07:20:50]

On 2013/06/10 07:20:13, ahe wrote:
> What is this change about?
> 
> Why are you making changes to the test infrastructure without coordinating
with
> the test team?
> 
> Are you planning to ship sdk/bin/dart2analyzer as part of the SDK, if so why
do
> we need to analyzers in the SDK?

I meant: "why do we need to analyzers in the SDK?"

[kustermann, 2013-06-10 07:57:07]

On 2013/06/10 07:20:50, ahe wrote:
> On 2013/06/10 07:20:13, ahe wrote:
> > What is this change about?
> > 
> > Why are you making changes to the test infrastructure without coordinating
> with
> > the test team?
> > 
> > Are you planning to ship sdk/bin/dart2analyzer as part of the SDK, if so why
> do
> > we need to analyzers in the SDK?
> 
> I meant: "why do we need to analyzers in the SDK?"

I wasn't aware of this CL either.
I guess you want to move slowly over to the java2dart'ed analyzer and want to
get testing support for it?
We could probably also setup a builder on FYI for this.

One DBC about the CL: I don't see a real reason why you need to duplicate the
status file -- the differences are pretty small.