Issue 16357003: Revert revision 23575.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16357003: Revert revision 23575. (Closed)

Created:
7 years, 6 months ago by ricow1

Modified:
7 years, 6 months ago

Reviewers:
Johnni Winther, dgrove, Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert revision 23575. This is causing failures in the test of dartdoc (on the editor bot) The reason seems to be that we are generating a temporary nav.dart file relative to the dartdocPath in sdk/lib/_internal/dartdoc/lib/ which we claim to be part of in sdk/lib/_internal/dartdoc/lib/src/client/client-static.dart. This will not work since actual code has been snapshot. Committed: https://code.google.com/p/dart/source/detail?r=23583

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -39 lines)			Patch
M	sdk/bin/dartdoc	View	1 chunk	+4 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/bin/dartdoc.dart	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	utils/compiler/compiler.gyp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	utils/compiler/create_snapshot.dart	View	6 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r23583 (presubmit successful).

7 years, 6 months ago (2013-06-04 09:36:26 UTC) #2

Message was sent while issue was closed.

TBR

Expand Messages | Collapse Messages