Add 'startPaused' option to Isolate.spawn*.

Add 'startPaused' option to Isolate.spawn*.

Initial implementation of startPaused in dart2js.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32722

[Lasse Reichstein Nielsen, 2014-02-14 12:17:49]

I made the "startPaused" use the pauseCapability of the isolate itself as
marker. 

If we ever have an isolate that you can't start paused, it's probably because it
can't pause at all, and it won't have a pause capability then.

[kasperl, 2014-02-14 13:40:31]

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/isolate/isolate....
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/isolate/isolate....
sdk/lib/isolate/isolate.dart:62: { bool startPaused: false });
Wouldn't 'paused' be enough? The fact that you're calling spawn is indication
enough that you're talking about the starting state.

[floitsch, 2014-02-14 14:21:37]

LGTM.

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/_internal/lib/is...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/_internal/lib/is...
sdk/lib/_internal/lib/isolate_helper.dart:745: void runStartFunction() {
new line before and after nested function.

https://codereview.chromium.org/163523003/diff/50001/tests/isolate/start_paus...
File tests/isolate/start_paused_test.dart (right):

https://codereview.chromium.org/163523003/diff/50001/tests/isolate/start_paus...
tests/isolate/start_paused_test.dart:25: // Test that a paused isolate don't
send events.
doesn't

https://codereview.chromium.org/163523003/diff/50001/tests/isolate/start_paus...
tests/isolate/start_paused_test.dart:25: // Test that a paused isolate don't
send events.
Add a small description of how you test:
"We spawn two isolates. One paused the other not. We wait for a reply from the
second isolate before we resume the first isolate.
This is not a full-proof test, since isolates are not required to send messages
in order."

https://codereview.chromium.org/163523003/diff/50001/tests/isolate/start_paus...
tests/isolate/start_paused_test.dart:26: asyncStart();
missing asyncEnd

https://codereview.chromium.org/163523003/diff/50001/tests/isolate/start_paus...
tests/isolate/start_paused_test.dart:45: // Test that a paused isolate don't
send events.
doesn't

https://codereview.chromium.org/163523003/diff/50001/tests/isolate/start_paus...
tests/isolate/start_paused_test.dart:46: asyncStart();
missing asyncEnd

[Lasse Reichstein Nielsen, 2014-02-17 13:06:14]

Committed patchset #4 manually as r32722 (presubmit successful).

[Lasse Reichstein Nielsen, 2014-02-18 08:13:35]

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/_internal/lib/is...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/_internal/lib/is...
sdk/lib/_internal/lib/isolate_helper.dart:745: void runStartFunction() {
On 2014/02/14 14:21:38, floitsch wrote:
> new line before and after nested function.

Done.

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/isolate/isolate....
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/163523003/diff/50001/sdk/lib/isolate/isolate....
sdk/lib/isolate/isolate.dart:62: { bool startPaused: false });
Fine with me. Shorter is better.