Issue 16347011: Hide IOException from java_core.dart in analyzer_experimental.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16347011: Hide IOException from java_core.dart in analyzer_experimental. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Hide IOException from java_core.dart in analyzer_experimental. BUG= Committed: https://code.google.com/p/dart/source/detail?r=23850

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	pkg/analyzer_experimental/lib/src/generated/sdk_io.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/source_io.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r23850 (presubmit successful).

7 years, 6 months ago (2013-06-11 13:35:14 UTC) #2

scheglov

7 years, 6 months ago (2013-06-11 16:29:04 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/16347011/diff/1/editor/util/plugins/com.googl...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java
(right):

https://codereview.chromium.org/16347011/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java:535:
unit.getDirectives().add(importDirective(src_package + "java_core.dart", null,
importHideCombinator('IOException')));
In Java single quotes are used for characters, not strings.
Steve fixed this problem.

Expand Messages | Collapse Messages