Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 16336022: Fixing a number of Dart2JS compiler warnings. (Closed)

Created:
7 years, 6 months ago by blois
Modified:
7 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing a number of Dart2JS compiler warnings. BUG=11039 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=23569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -109 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 11 chunks +14 lines, -57 lines 0 comments Download
M sdk/lib/html/html_common/conversions.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/src/dart2js_Conversions.dart View 1 chunk +0 lines, -43 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 6 months ago (2013-06-03 21:02:37 UTC) #1
Emily Fortuna
lgtm
7 years, 6 months ago (2013-06-03 21:09:44 UTC) #2
blois
7 years, 6 months ago (2013-06-03 21:11:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698