Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 16336021: Create specific null read only handles for the frequently used types (Closed)

Created:
7 years, 6 months ago by siva
Modified:
7 years, 6 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create specific null read only handles for the frequently used types Array, String, Instance, Object and use them. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23785

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -23 lines) Patch
M runtime/vm/class_finalizer.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 4 chunks +26 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 15 chunks +32 lines, -12 lines 0 comments Download
M runtime/vm/parser.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
Address review comments.
7 years, 6 months ago (2013-06-03 21:23:37 UTC) #1
Ivan Posva
LGTM -ip
7 years, 6 months ago (2013-06-07 21:32:57 UTC) #2
siva
7 years, 6 months ago (2013-06-08 00:47:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698