Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 16335012: Fixing some of the tests disabled from the chrome IDL roll. (Closed)

Created:
7 years, 6 months ago by blois
Modified:
7 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing some of the tests disabled from the chrome IDL roll. Basically some native constructors were added which are not yet cross-platform, so skipping them for now. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=23564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -273 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 7 chunks +26 lines, -91 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +27 lines, -93 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +14 lines, -0 lines 0 comments Download
D tools/dom/src/dart2js_FactoryProviders.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/dom/src/dartium_FactoryProviders.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/dom/src/shared_FactoryProviders.dart View 1 chunk +0 lines, -52 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +7 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +17 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Range.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Text.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 6 months ago (2013-06-03 19:39:29 UTC) #1
vsm
lgtm!
7 years, 6 months ago (2013-06-03 19:42:53 UTC) #2
blois
7 years, 6 months ago (2013-06-03 20:10:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698