Issue 16329002: Allow null strings in setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16329002: Allow null strings in setters. (Closed)

Created:
7 years, 6 months ago by Anton Muhin

Modified:
7 years, 6 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Allow null strings in setters. V8 generator always allows nulls for Reflect attributes of type DOMString. That looks somewhat hairy, but let's just follow the logic for Dart as well. R=podivilov@chromium.org BUG=8189 Committed: https://code.google.com/p/dart/source/detail?r=23541

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tools/dom/scripts/systemnative.py	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Anton Muhin

7 years, 6 months ago (2013-06-03 13:26:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23541 (presubmit successful).