Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 163273002: Add signal test for each supported signal. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add signal test for each supported signal. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32648

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
A tests/standalone/io/signal_test_script.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M tests/standalone/io/signals_test.dart View 1 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-13 10:44:35 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/163273002/diff/1/tests/standalone/io/signals_test.dart File tests/standalone/io/signals_test.dart (right): https://codereview.chromium.org/163273002/diff/1/tests/standalone/io/signals_test.dart#newcode53 tests/standalone/io/signals_test.dart:53: process.stderr.transform(UTF8.decoder).listen(print); Debug print? https://codereview.chromium.org/163273002/diff/1/tests/standalone/io/signals_test.dart#newcode91 tests/standalone/io/signals_test.dart:91: Don't you need ...
6 years, 10 months ago (2014-02-13 10:54:26 UTC) #2
Anders Johnsen
https://codereview.chromium.org/163273002/diff/1/tests/standalone/io/signals_test.dart File tests/standalone/io/signals_test.dart (right): https://codereview.chromium.org/163273002/diff/1/tests/standalone/io/signals_test.dart#newcode53 tests/standalone/io/signals_test.dart:53: process.stderr.transform(UTF8.decoder).listen(print); On 2014/02/13 10:54:27, Søren Gjesse wrote: > Debug ...
6 years, 10 months ago (2014-02-13 12:08:02 UTC) #3
Anders Johnsen
6 years, 10 months ago (2014-02-13 12:08:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r32648 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698