Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 16325009: Remove error throw on bad DEFINES (Closed)

Created:
7 years, 6 months ago by vsm
Modified:
7 years, 6 months ago
Reviewers:
Anton Muhin, antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove error throw on bad DEFINES We need to be forgiving here for Android builds. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=23547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/dom/scripts/fremontcutbuilder.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 6 months ago (2013-06-03 15:04:07 UTC) #1
Anton Muhin
lgtm
7 years, 6 months ago (2013-06-03 15:04:49 UTC) #2
vsm
7 years, 6 months ago (2013-06-03 15:44:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698