Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 16322002: Revert revision 23438. (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
Bob Nystrom, kasperl
CC:
reviews_dartlang.org, ahe, dgrove
Visibility:
Public.

Description

Revert revision 23438. Revision 23438 is disabling the ability to run dart2js from the repo without building the sdk. Lets discuss how we fix this for pub without having to build the sdk. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -47 lines) Patch
M sdk/bin/dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/bin/pub View 1 chunk +8 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
7 years, 6 months ago (2013-06-03 07:29:00 UTC) #1
ricow1
7 years, 6 months ago (2013-06-03 07:29:30 UTC) #2
kasperl
LGTM :-(
7 years, 6 months ago (2013-06-03 07:29:58 UTC) #3
ricow1
Committed patchset #1 manually as r23523 (presubmit successful).
7 years, 6 months ago (2013-06-03 07:30:24 UTC) #4
Bob Nystrom
7 years, 6 months ago (2013-06-03 15:16:47 UTC) #5
Message was sent while issue was closed.
LGTM. I can probably hack around this limitation in pub.

Powered by Google App Engine
This is Rietveld 408576698