Issue 16320003: Make fields of BoundClosure private to not expose implementation details.

Issue 16320003: Make fields of BoundClosure private to not expose implementation details. (Closed)

Created:
7 years, 6 months ago by ngeoffray

Modified:
7 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, sra1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make fields of BoundClosure private to not expose implementation details. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23524

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download
	A	tests/language/closure_internals_test.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://codereview.chromium.org/16320003/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart File sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right): https://codereview.chromium.org/16320003/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart#newcode966 sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:966: self.hashCode, This needs testing (and fixing).

7 years, 6 months ago (2013-06-03 07:14:53 UTC) #2

ngeoffray

7 years, 6 months ago (2013-06-03 07:26:39 UTC) #3

ngeoffray

7 years, 6 months ago (2013-06-03 07:30:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r23524 (presubmit successful).

Expand Messages | Collapse Messages