Add a StreamChannelCompleter class.

Add a StreamChannelCompleter class.

This is by analogy with StreamCompleter and StreamSinkCompleter in the
async package, and is in fact implemented using them.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/stream_channel/commit/553249599e1cb592f2025b5643b9da6d44883661

[Bob Nystrom, 2016-01-26 19:00:18]

lgtm

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
File lib/src/stream_channel_completer.dart (right):

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
lib/src/stream_channel_completer.dart:28: bool _set = false;
Instead of a separate field, can you just do:

_streamCompleter.stream != null || _sinkCompleter.sink != null

?

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
lib/src/stream_channel_completer.dart:54: /// call any of them again will fail.
"any" -> "either".

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
lib/src/stream_channel_completer.dart:69: /// call any of them again will fail.
Ditto.

[nweiz, 2016-01-26 23:24:54]

Code review changes

[nweiz, 2016-01-26 23:24:57]

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
File lib/src/stream_channel_completer.dart (right):

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
lib/src/stream_channel_completer.dart:28: bool _set = false;
On 2016/01/26 19:00:18, Bob Nystrom wrote:
> Instead of a separate field, can you just do:
> 
> _streamCompleter.stream != null || _sinkCompleter.sink != null
> 
> ?

No, the point of a completer is that the object it exposes exists even before
it's completed.

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
lib/src/stream_channel_completer.dart:54: /// call any of them again will fail.
On 2016/01/26 19:00:18, Bob Nystrom wrote:
> "any" -> "either".

Done.

https://codereview.chromium.org/1631103002/diff/1/lib/src/stream_channel_comp...
lib/src/stream_channel_completer.dart:69: /// call any of them again will fail.
On 2016/01/26 19:00:18, Bob Nystrom wrote:
> Ditto.

Done.

[nweiz, 2016-01-26 23:25:14]

Description was changed from

==========
Add a StreamChannelCompleter class.

This is by analogy with StreamCompleter and StreamSinkCompleter in the
async package, and is in fact implemented using them.

R=rnystrom@google.com
==========

to

==========
Add a StreamChannelCompleter class.

This is by analogy with StreamCompleter and StreamSinkCompleter in the
async package, and is in fact implemented using them.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/stream_channel/commit/553249599e1cb592f2025b5643...
==========

[nweiz, 2016-01-26 23:25:15]

Committed patchset #2 (id:20001) manually as
553249599e1cb592f2025b5643b9da6d44883661 (presubmit successful).