IDL roll and expectations fix

IDL roll and expectations fix

To the latest Blink.

TBR=blois

Committed: https://code.google.com/p/dart/source/detail?r=23516

[vsm, 2013-06-02 22:46:07]

Committed patchset #1 manually as r23516 (presubmit successful).

[Anton Muhin, 2013-06-03 07:52:14]

DBC

Do you know what overall goes on with item methods---I can see many added and I
wonder if at least some of those classes should be mapped to Dart collections
now.

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:7218: String None(String name);
this one looks weird: apparently we've got None as Python's None somewhere.

Chances are it is same named getter.

[Anton Muhin, 2013-06-03 08:52:41]

One more DBC

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:2073: CssKeyframeRule item(int index)
native;
looking into IDLs changes, is that the code we'd like to generate, see
https://codereview.appspot.com/9889044/diff/1/core/css/WebKitCSSKeyframesRule...

I wonder if it should be plain [] operator, thoughts?

[vsm, 2013-06-03 14:47:40]

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:2073: CssKeyframeRule item(int index)
native;
We should discuss.  Should getter be always mapped to []?  Depending on the arg
types?  Sometimes it's int, sometimes String.

On 2013/06/03 08:52:41, Anton Muhin wrote:
> looking into IDLs changes, is that the code we'd like to generate, see
>
https://codereview.appspot.com/9889044/diff/1/core/css/WebKitCSSKeyframesRule...
> 
> I wonder if it should be plain [] operator, thoughts?

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:7218: String None(String name);
Good catch.  The IDL has dropped the name for this getter.  Instead, there is an
ImplementedAs attribute.  We should get the name from here.  (And, in this case,
consider whether to map this to [].)


On 2013/06/03 07:52:14, Anton Muhin wrote:
> this one looks weird: apparently we've got None as Python's None somewhere.
> 
> Chances are it is same named getter.

[Anton Muhin, 2013-06-03 15:11:31]

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:2073: CssKeyframeRule item(int index)
native;
I'd always map.  Strict rule: if there is a getter with a single argument, map
it to [].

On 2013/06/03 14:47:41, vsm wrote:
> We should discuss.  Should getter be always mapped to []?  Depending on the
arg
> types?  Sometimes it's int, sometimes String.
> 
> On 2013/06/03 08:52:41, Anton Muhin wrote:
> > looking into IDLs changes, is that the code we'd like to generate, see
> >
>
https://codereview.appspot.com/9889044/diff/1/core/css/WebKitCSSKeyframesRule...
> > 
> > I wonder if it should be plain [] operator, thoughts?
>

[blois, 2013-06-03 17:34:43]

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/16311002/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:2067: @JSName('None')
I'm presuming that this doesn't work in dart2js yet (None is not the JS function
name...)