Issue 16309014: Add support for binary stdout/stderr data when using Process.run

Issue 16309014: Add support for binary stdout/stderr data when using Process.run (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for binary stdout/stderr data when using Process.run R=ajohnsen@google.com BUG=http://dartbug.com/9167 Committed: https://code.google.com/p/dart/source/detail?r=23962

Patch Set 2 : Removed debug print #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -37 lines)			Patch
M	runtime/bin/process_patch.dart	View	1	3 chunks	+33 lines, -28 lines	2 comments	Download
M	sdk/lib/io/process.dart	View		1 chunk	+10 lines, -4 lines	0 comments	Download
M	sdk/lib/io/string_transformer.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/standalone/io/process_run_output_test.dart	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	tests/standalone/io/process_std_io_script2.dart	View		3 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/16309014/diff/3001/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/16309014/diff/3001/runtime/bin/process_patch.dart#newcode340 runtime/bin/process_patch.dart:340: if (stdoutEncoding == null) stdoutEncoding = Encoding.BINARY; Why ...

7 years, 6 months ago (2013-06-13 09:02:07 UTC) #2

Søren Gjesse

https://codereview.chromium.org/16309014/diff/3001/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/16309014/diff/3001/runtime/bin/process_patch.dart#newcode340 runtime/bin/process_patch.dart:340: if (stdoutEncoding == null) stdoutEncoding = Encoding.BINARY; On 2013/06/13 ...

7 years, 6 months ago (2013-06-13 10:27:12 UTC) #3

Søren Gjesse

7 years, 6 months ago (2013-06-13 10:28:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23962 (presubmit successful).

Expand Messages | Collapse Messages