Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 16293005: Don't use 'fail, OK' except of co19 (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use 'fail, OK' except of co19 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -95 lines) Patch
M tests/isolate/isolate.status View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +41 lines, -41 lines 0 comments Download
M tests/language/language_analyzer2.status View 5 chunks +41 lines, -46 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 6 months ago (2013-06-07 19:44:18 UTC) #1
Brian Wilkerson
LGTM. Thanks for taking care of this!
7 years, 6 months ago (2013-06-07 19:46:46 UTC) #2
scheglov
7 years, 6 months ago (2013-06-07 19:49:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698