Better documentation on Sets and Maps, and more.

Better documentation on Sets and Maps.
Small updates on other documentation too.

BUG= http://dartbug.com/474, http://dartbug.com/1289, http://dartbug.com/5516, http://dartbug.com/10902, http://dartbug.com/10315
R=floitsch@google.com, ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23734

[Lasse Reichstein Nielsen, 2013-06-04 11:44:28]

Adding VM/dart2js people because I touch their libraries.

[ngeoffray, 2013-06-04 11:51:33]

LGTM

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/hash_ma...
File sdk/lib/collection/hash_map.dart (right):

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/hash_ma...
sdk/lib/collection/hash_map.dart:13: * anti-symmetric, trasitive, and consistent
over time), and that `hashCode`
trasitive -> transitive

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/hash_ma...
sdk/lib/collection/hash_map.dart:16: * The map allows `null` as an key.
an -> a

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/hash_se...
File sdk/lib/collection/hash_set.dart (right):

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/hash_se...
sdk/lib/collection/hash_set.dart:65: * anti-symmetric, trasitive, and consistent
over time), and that `hashCode`
trasitive -> transitive

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/linked_...
File sdk/lib/collection/linked_hash_map.dart (right):

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/linked_...
sdk/lib/collection/linked_hash_map.dart:16: * anti-symmetric, trasitive, and
consistent over time), and that `hashCode`
trasitive -> transitive

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/linked_...
sdk/lib/collection/linked_hash_map.dart:19: * The map allows `null` as an key.
an -> a

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/linked_...
File sdk/lib/collection/linked_hash_set.dart (right):

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/linked_...
sdk/lib/collection/linked_hash_set.dart:10: * The `LinkedHashSet` also keep
track of the order that elements were inserted
keep -> keeps

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/collection/linked_...
sdk/lib/collection/linked_hash_set.dart:16: * anti-symmetric, trasitive, and
consistent over time), and that `hashCode`
trasitive -> transitive

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/core/set.dart
File sdk/lib/core/set.dart (right):

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/core/set.dart#newc...
sdk/lib/core/set.dart:75: * Removes all elements of this set that are not an
element in [elements].
an element -> elements

https://codereview.chromium.org/16285004/diff/8001/sdk/lib/core/set.dart#newc...
sdk/lib/core/set.dart:90: * Returns `true` if this Set contains all the elements
of [other].
-> Returns whether

[Lasse Reichstein Nielsen, 2013-06-04 14:14:06]

All typos fixed. Thanks!

[floitsch, 2013-06-06 14:00:52]

LGTM.

https://codereview.chromium.org/16285004/diff/5004/sdk/lib/collection/hash_ma...
File sdk/lib/collection/hash_map.dart (right):

https://codereview.chromium.org/16285004/diff/5004/sdk/lib/collection/hash_ma...
sdk/lib/collection/hash_map.dart:13: * anti-symmetric, trasnitive, and
consistent over time), and that `hashCode`
transitive

https://codereview.chromium.org/16285004/diff/5004/sdk/lib/collection/hash_ma...
sdk/lib/collection/hash_map.dart:16: * The map allows `null` as a key.
Should we add that the equivalence relationship does not work for doubles if
"NaN" is used?

https://codereview.chromium.org/16285004/diff/16001/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/16285004/diff/16001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:168: * Converts [this] as a [double] to a string
representation with
"Converts `this` to a [double] and then applies `toStringAsFixed` on the
result." ?


Should we just say that this is equivalent to:
this.toDouble().toStringAsFixed().

See [double.toStringAsFixed].

?

[Lasse Reichstein Nielsen, 2013-06-07 08:51:49]

Committed patchset #8 manually as r23734 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-06-10 05:48:50]

https://codereview.chromium.org/16285004/diff/5004/sdk/lib/collection/hash_ma...
File sdk/lib/collection/hash_map.dart (right):

https://codereview.chromium.org/16285004/diff/5004/sdk/lib/collection/hash_ma...
sdk/lib/collection/hash_map.dart:13: * anti-symmetric, trasnitive, and
consistent over time), and that `hashCode`
But I changed that! Really!
Grumble!

https://codereview.chromium.org/16285004/diff/5004/sdk/lib/collection/hash_ma...
sdk/lib/collection/hash_map.dart:16: * The map allows `null` as a key.
That is a property of doubles, which should be noted on the double type:
"doesn't play well with hash maps".

https://codereview.chromium.org/16285004/diff/16001/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/16285004/diff/16001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:168: * Converts [this] as a [double] to a string
representation with
On 2013/06/06 14:00:53, floitsch wrote:
> "Converts `this` to a [double] and then applies `toStringAsFixed` on the
> result." ?

Done.

> Should we just say that this is equivalent to:
> this.toDouble().toStringAsFixed().

That would seem like a recursive definition, since double is a num.
I know that double has its own version, but that means that this description
really only applies to int - which is weird, so I try to write this so it
applies to both int and double.

> See [double.toStringAsFixed].
> 
> ?