Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 16278009: Run 'analyzer' tests with '--show-package-warnings' flag. (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 4 months ago
Reviewers:
ricow1, Brian Wilkerson
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Run 'analyzer' tests with '--show-package-warnings' flag. This does not make any new tests to pass or fail though. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23633

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M sdk/bin/dartanalyzer_developer View 1 chunk +15 lines, -1 line 1 comment Download
M tools/testing/dart/test_suite.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 6 months ago (2013-06-05 01:22:35 UTC) #1
Brian Wilkerson
LGTM
7 years, 6 months ago (2013-06-05 02:50:40 UTC) #2
scheglov
Committed patchset #1 manually as r23633 (presubmit successful).
7 years, 6 months ago (2013-06-05 15:27:01 UTC) #3
ricow1
7 years, 4 months ago (2013-08-07 08:53:09 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/16278009/diff/1/sdk/bin/dartanalyzer_developer
File sdk/bin/dartanalyzer_developer (right):

https://codereview.chromium.org/16278009/diff/1/sdk/bin/dartanalyzer_develope...
sdk/bin/dartanalyzer_developer:50: if [ $FOUND_BATCH = 0 ] ; then
what is FOUND_BATCH here - I don't see it defined anywhere

Powered by Google App Engine
This is Rietveld 408576698