Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 16278004: Report warning on unresolved unqualified access. (Closed)

Created:
7 years, 6 months ago by Johnni Winther
Modified:
7 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report warning on unresolved unqualified access. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=23726

Patch Set 1 #

Patch Set 2 : Test added. #

Patch Set 3 : Cleanup white-list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -14 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 2 7 chunks +181 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 6 months ago (2013-06-03 13:34:30 UTC) #1
karlklose
LGTM.
7 years, 6 months ago (2013-06-06 13:09:19 UTC) #2
Johnni Winther
7 years, 6 months ago (2013-06-07 06:56:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r23726 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698