Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 162413002: Reapply "remove html warnings." (Closed)

Created:
6 years, 10 months ago by Emily Fortuna
Modified:
6 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "remove html warnings." BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=32641

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -137 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 29 chunks +123 lines, -77 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 17 chunks +98 lines, -41 lines 0 comments Download
M sdk/lib/html/html_common/lists.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/dom/dom.json View 3 chunks +8 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 3 chunks +3 lines, -0 lines 1 comment Download
M tools/dom/src/CrossFrameTypes.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/src/WrappedEvent.dart View 2 chunks +41 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_AbstractWorker.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +7 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
one weird change makes Dartium run! https://codereview.chromium.org/162413002/diff/20001/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/162413002/diff/20001/tools/dom/scripts/htmlrenamer.py#newcode81 tools/dom/scripts/htmlrenamer.py:81: 'DocumentType', This is ...
6 years, 10 months ago (2014-02-13 01:34:18 UTC) #1
blois
lgtm
6 years, 10 months ago (2014-02-13 01:37:06 UTC) #2
Emily Fortuna
6 years, 10 months ago (2014-02-13 01:43:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r32641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698