Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 16223010: Update and re-enable with_server_rejected_credentials_authenticates_again_test. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update and re-enable with_server_rejected_credentials_authenticates_again_test. BUG=https://code.google.com/p/dart/issues/detail?id=9839 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=23839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M sdk/lib/_internal/pub/pub.status View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
I'm not able to reproduce this issue, with the updated test.
7 years, 6 months ago (2013-06-10 14:14:17 UTC) #1
nweiz
LGTM Please keep an eye on the tests to see if this flakes again.
7 years, 6 months ago (2013-06-10 20:22:17 UTC) #2
Anders Johnsen
7 years, 6 months ago (2013-06-11 07:02:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698