Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 162223002: Add --compile flag. (Closed)

Created:
6 years, 10 months ago by dgrove
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -30 lines) Patch
M pkg/docgen/bin/docgen.dart View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 2 3 4 8 chunks +38 lines, -28 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
dgrove
6 years, 10 months ago (2014-02-12 23:57:01 UTC) #1
Emily Fortuna
https://codereview.chromium.org/162223002/diff/40001/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/162223002/diff/40001/pkg/docgen/bin/docgen.dart#newcode132 pkg/docgen/bin/docgen.dart:132: '(if not already present) and start a simple server', ...
6 years, 10 months ago (2014-02-13 00:27:56 UTC) #2
dgrove
ptal https://codereview.chromium.org/162223002/diff/40001/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/162223002/diff/40001/pkg/docgen/bin/docgen.dart#newcode132 pkg/docgen/bin/docgen.dart:132: '(if not already present) and start a simple ...
6 years, 10 months ago (2014-02-13 00:58:40 UTC) #3
Alan Knight
lgtm
6 years, 10 months ago (2014-02-13 01:07:00 UTC) #4
dgrove
Committed patchset #5 manually as r32639 (presubmit successful).
6 years, 10 months ago (2014-02-13 01:07:21 UTC) #5
kevmoo
6 years, 10 months ago (2014-02-19 21:57:15 UTC) #6
Message was sent while issue was closed.
Oops...

https://codereview.chromium.org/162223002/diff/180001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (left):

https://codereview.chromium.org/162223002/diff/180001/pkg/docgen/lib/docgen.d...
pkg/docgen/lib/docgen.dart:696: static void _moveDirectoryAndServe() {
Still being used...

https://code.google.com/p/dart/issues/detail?id=16959

Powered by Google App Engine
This is Rietveld 408576698