Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 162163002: Make cycle checking of super interfaces linear instead of quadratic by marking (Closed)

Created:
6 years, 10 months ago by regis
Modified:
6 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make cycle checking of super interfaces linear instead of quadratic by marking classes as checked (issue 16343). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32636

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -13 lines) Patch
M runtime/vm/class_finalizer.cc View 6 chunks +32 lines, -7 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +6 lines, -1 line 0 comments Download
M tests/co19/co19-dartium.status View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
6 years, 10 months ago (2014-02-12 23:39:09 UTC) #1
siva
lgtm
6 years, 10 months ago (2014-02-13 00:13:42 UTC) #2
regis
6 years, 10 months ago (2014-02-13 00:14:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698