Add quotes to make it easier to copy paste around.

Add quotes to make it easier to copy paste around.

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23411

[Emily Fortuna, 2013-05-29 17:56:16]

https://codereview.chromium.org/16194005/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/16194005/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1184: return
dartDir.append('"/client/tests/drt/Content Shell.app/Contents/'
I think you actually want this:

return '"${dartDir.append('/client......Content Shell').toNativePath()}"';

because dartDir has a partial path value already and we want quotes around the
whole thing. Quotes on the inside confuses append. :-)

[Anton Muhin, 2013-05-29 18:16:13]

https://codereview.chromium.org/16194005/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/16194005/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1184: return
dartDir.append('"/client/tests/drt/Content Shell.app/Contents/'
My bad, thanks a lot for spotting.

BTW, shouldn't we always quote paths as dartDir potentially may already have
spaces?

On 2013/05/29 17:56:16, Emily Fortuna wrote:
> I think you actually want this:
> 
> return '"${dartDir.append('/client......Content Shell').toNativePath()}"';
> 
> because dartDir has a partial path value already and we want quotes around the
> whole thing. Quotes on the inside confuses append. :-)

[Emily Fortuna, 2013-05-29 18:40:51]

lgtm. 

I think up until now our paths generally haven't had spaces in them (even though
it's possible they could on some systems), so we weren't quoting the paths.
Doesn't mean we shouldn't, it's just we hadn't run into it much yet.

[Anton Muhin, 2013-05-30 13:34:57]

Committed patchset #2 manually as r23411 (presubmit successful).