Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 161893002: Automatically pass SDK into docgen.dart, and use the SDK for running (Closed)

Created:
6 years, 10 months ago by dgrove
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Automatically pass SDK into docgen.dart, and use the SDK for running pub and the Dart binary. This removes the need to have the SDK in the PATH when running docgen. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
pkg/docgen/bin/docgen.dart View 3 chunks +11 lines, -0 lines 0 comments Download
pkg/docgen/lib/docgen.dart View 7 chunks +21 lines, -9 lines 0 comments Download
sdk/bin/docgen View 1 chunk +5 lines, -4 lines 0 comments Download
sdk/bin/docgen.bat View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dgrove
6 years, 10 months ago (2014-02-12 23:05:06 UTC) #1
Emily Fortuna
lgtm
6 years, 10 months ago (2014-02-12 23:22:04 UTC) #2
dgrove
6 years, 10 months ago (2014-02-12 23:23:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698