Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16188008: Handle fields/getter of mixed-in classes. (Closed)

Created:
7 years, 6 months ago by polux
Modified:
7 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle fields/getter of mixed-in classes. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=23672

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Sync #

Total comments: 2

Patch Set 4 : cleanup #

Patch Set 5 : sync and fix wording in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 2 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
polux
This CL uses CL 15949008 as a diffbase.
7 years, 6 months ago (2013-05-30 13:38:03 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/16188008/diff/10001/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/16188008/diff/10001/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1950 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1950: //print("$node $selector"); Remove debug code.
7 years, 6 months ago (2013-06-06 10:58:53 UTC) #2
polux
https://codereview.chromium.org/16188008/diff/10001/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/16188008/diff/10001/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1950 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1950: //print("$node $selector"); On 2013/06/06 10:58:53, karlklose wrote: > Remove ...
7 years, 6 months ago (2013-06-06 11:01:20 UTC) #3
polux
7 years, 6 months ago (2013-06-06 11:06:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as r23672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698