Correctly implemented removeWhere and retainWhere for elements in dart:html.

Correctly implemented removeWhere and retainWhere for elements in dart:html.

BUG=
R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23366

[blois, 2013-05-29 20:15:57]

https://codereview.chromium.org/16171012/diff/2002/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/16171012/diff/2002/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Element.darttemplate:72: 
why not:

if (retainMatching)
  removed = _element.children.where((e) => !test(e));
else:
  removed = _element.children.where(test);

for (var e in removed)
  e.remove();

https://codereview.chromium.org/16171012/diff/2002/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Element.darttemplate:82: 
Seems like it would be better to have a list of the removed, then go through and
call .remove() on each at the end?

[Emily Fortuna, 2013-05-29 20:29:19]

PTAL. 

I had it written the other way because I was mirroring the way it was written in
the original ListBase class, but this is more readable.

[blois, 2013-05-29 21:20:59]

lgtm

[Emily Fortuna, 2013-05-29 21:22:33]

Committed patchset #2 manually as r23366 (presubmit successful).