Issue 16162005: Add compileAll internal compiler flag.

Issue 16162005: Add compileAll internal compiler flag. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, Johnni Winther, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add compileAll internal compiler flag. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=23858

Patch Set 2 : Issues discovered during testing #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -17 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	6 chunks	+24 lines, -12 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	1 chunk	+7 lines, -1 line	1 comment	Download
M	dart/tests/compiler/dart2js/mock_compiler.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tests/lib/mirrors/disable_tree_shaking_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/16162005/diff/2001/dart/tests/lib/mirrors/disable_tree_shaking_test.dart File dart/tests/lib/mirrors/disable_tree_shaking_test.dart (right): https://codereview.chromium.org/16162005/diff/2001/dart/tests/lib/mirrors/disable_tree_shaking_test.dart#newcode8 dart/tests/lib/mirrors/disable_tree_shaking_test.dart:8: import "dart:mirrors"; This creates a 657K file (290K minified, ...

7 years, 6 months ago (2013-06-10 18:11:15 UTC) #1

ngeoffray

LGTM, but https://codereview.chromium.org/16162005/diff/2001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/16162005/diff/2001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode910 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:910: // interceptor classes. But it is compiling ...

7 years, 6 months ago (2013-06-10 19:21:00 UTC) #2

ahe

https://codereview.chromium.org/16162005/diff/2001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/16162005/diff/2001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode910 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:910: // interceptor classes. On 2013/06/10 19:21:00, ngeoffray wrote: > ...

7 years, 6 months ago (2013-06-11 14:24:45 UTC) #3

ahe

https://codereview.chromium.org/16162005/diff/7001/dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/16162005/diff/7001/dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode764 dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:764: // Work around a problem compiling JSNull's constructor. I ...

7 years, 6 months ago (2013-06-11 15:43:00 UTC) #4

ahe

7 years, 6 months ago (2013-06-11 15:43:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r23858 (presubmit successful).

Expand Messages | Collapse Messages