Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 16140008: dart:io | Make FileStat.stat throw an exception when the file does not exist, or cannot be accessed. (Closed)

Created:
7 years, 6 months ago by Bill Hesse
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Make FileStat.stat throw an exception when the file does not exist, or cannot be accessed. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -40 lines) Patch
M runtime/bin/file.cc View 2 chunks +24 lines, -15 lines 0 comments Download
M runtime/bin/file_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/standalone/io/file_stat_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
The error is nice and readable too: FileIOException: Error getting stat of '/tmp/temp_dir1_gnClN9/file' (OS Error: ...
7 years, 6 months ago (2013-06-03 13:54:07 UTC) #1
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-03 14:59:10 UTC) #2
Bill Hesse
7 years, 6 months ago (2013-06-03 15:01:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23543 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698