Issue 16137009: Fix issue 10898 by fixing the ByteData constructor to implicitly create an ArrayBuffer.

Issue 16137009: Fix issue 10898 by fixing the ByteData constructor to implicitly create an ArrayBuffer. (Closed)

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
vsm, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix issue 10898 by fixing the ByteData constructor to implicitly create an ArrayBuffer. R=ngeoffray@google.com BUG=http://dartbug.com/10898 Committed: https://code.google.com/p/dart/source/detail?r=23393

Patch Set 2 : Fix length <-> byteLength issue. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -31 lines)			Patch
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	1	2 chunks	+6 lines, -16 lines	0 comments	Download
M	tests/lib/lib.status	View		3 chunks	+9 lines, -15 lines	0 comments	Download
A	tests/lib/typed_data/byte_data_test.dart	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/16137009/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/16137009/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode129 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:129: factory ByteData.view(ByteBuffer buffer, [int byteOffset, int byteLength]) => ...

7 years, 6 months ago (2013-05-30 09:51:57 UTC) #2

kasperl

https://codereview.chromium.org/16137009/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/16137009/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode129 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:129: factory ByteData.view(ByteBuffer buffer, [int byteOffset, int byteLength]) => On ...

7 years, 6 months ago (2013-05-30 10:30:55 UTC) #3

kasperl

Committed patchset #2 manually as r23393 (presubmit successful).

7 years, 6 months ago (2013-05-30 10:37:33 UTC) #4

Message was sent while issue was closed.

lgtm - thanks!

Expand Messages | Collapse Messages