Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 16136014: Make AST generation deterministic: always call a static getter if it exists, regardless if the stat… (Closed)

Created:
7 years, 6 months ago by srdjan
Modified:
7 years, 6 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make AST generation deterministic: always call a static getter if it exists, regardless if the statuic field was initialized or not. Previously we may have created a LoadStaticFieldNode dependgin if the static field was already intialized at compile time. Note that we do not generate implicit static getter nodes if their initialization is trivial. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=23825

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M runtime/vm/parser.cc View 1 2 3 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 6 months ago (2013-06-10 18:25:27 UTC) #1
hausner
lgtm
7 years, 6 months ago (2013-06-10 18:44:55 UTC) #2
srdjan
7 years, 6 months ago (2013-06-10 19:32:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r23825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698